Errata

It is written:

"Let?s take all the old tests from NewItemTest, the ones that are about saving POST requests to existing lists, and move them into ListViewTest. As we do so, we also make them point at the base list URL, instead of ?/new_item:"

I believe it's mistake and the author means "/add_item" which is the word being used both urls.py and test_views.py. Example, in urls.py:

url(r'^(\d+)/add_item$', 'lists.views.add_item', name='add_item'),

Note from the Author or Editor:
am fixing this.

the class StaticLiveServerCase was renamed to StaticLiveServerTestCase in django 1.7 release.

https://code.djangoproject.com/ticket/23374

Note from the Author or Editor:
have fixed this in the latest version on atlas.

ch31l002 should also be prepended with "from lists.views import HomePageView"

Note from the Author or Editor:
Will fix.

In the epub 1st edition, the three assertions are improperly indented.

In my edition, the first self.assertTrue(..." is at the left margin, when it should be part of the test definiton (two tabs in).
2nd assertion, "self.assertIn(...." is correct
3rd assertion is back at the left margin.

It look some head-scratching to realize that they all had to be part of the test definition, and that the 2nd was correctly positioned, not the 1st and 3rd.

Note from the Author or Editor:
wontfix.

In the code block I see:

browser.get('http://localhost:8000')

On page 4, there is this sentence in the first paragraph:

You should see a browser window pop up, try and open up localhost:8001, and then the Python error message.

Either the code block should be modified to reference port 8001, or the sentence should be modified to reference port 8000. These are not consistent.

git status results should indicate that .gitignore has been modified:

On branch master

Initial commit

Changes to be committed:
(use "git rm --cached <file>..." to unstage)

new file: .gitignore
new file: functional_test.py
new file: manage.py
new file: superlists/__init__.py
new file: superlists/settings.py
new file: superlists/urls.py
new file: superlists/wsgi.py

Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git checkout -- <file>..." to discard changes in working directory)

modified: .gitignore

Note from the Author or Editor:
Well spotted! And very frustrating, my tests should have picked this up. turns out they weren't testing what I though they were, classic mistake.

I will fix it for the next edition.

The code sample is missing the concluding:

if __name__ == '__main__':
unittest.main()

... which is mentioned in the 5th bullet point immediately afterwards. Without it, the test simply returns with no output to the command line.

Cheers,
Mike

The sentence reads:

Well, a test failure means we?re allowed to change production code, so let?s open up the mysite/settings.py file.

I think the file settings.py should be in the folder superlists:

Well, a test failure means we?re allowed to change production code, so let?s open up the superlists/settings.py file.

assert wibble = 3
is a SyntaxError. It should be
assert wibble == 3

While retrieving saved items with Items.objects.all() it is assumed that objects are returned in order they're insterted in database. This is not true, without order_by() order returned is "in no particular order", thus that test may fail randomly. It's not even guaranteed that primary keys are in in order of insertion so there should be some column, like insertion time stamp for ordering purposes.

Note from the Author or Editor:
reader is correct, strictly speaking, although it's never been a problem. we're relying on an undocumented / unsupported feature, so that's not ideal. will have a think about how to address this

The paragraph states:

".. as well as a new file, db.sqlite3. Let?s add the first three, and then add the database to our .gitignore:"

But db.sqlite3 is already added to .gitignore (on page 8).

Note from the Author or Editor:
fixed in my latest draft

In Figure 6-1, the "Does the application need Refactoring" element lacks a "Yes" on the connection down to the Unit test cycle

Note from the Author or Editor:
yup. not sure i'm ever going to get round to fixing this though, it's a bit too much hassle...

I found moving the left margin by a fixed amount (-10px) didn't necessarily yield a pass. My window was slightly smaller, and thus I had to reduce it by -15px to pass.

This leads me to believe that the results of the test vary according to computer, which is not very robust. It seems to me that making the delta in "assertAlmostEqual" a fraction of the screen width as opposed to a fixed amount might be a more flexible solution (though this is only my opinion).

Note from the Author or Editor:
fixed in latest versions

lists/urls.py (ch06l045). is missing "from lists import views" in addtion to the django.conf import. Also as noted in author's github https://github.com/hjwp/book-example/blob/chapter_06/lists/urls.py

from django.conf.urls import url

from lists import views

Note from the Author or Editor:
fixed in latest version

Test fails as selenium is not installed.

Note from the Author or Editor:
ah yes, this can happen if we don't install selenium into the virtualenv. will see if i can clarify...

Should the following:
"... sudo restart gunicorn-superlists.ottg.eu"

actually be this?
"... sudo restart gunicorn-superlists-staging.ottg.eu"

Note that we're in the section where we're talking about the staging server, not where we're covering the live/production server.

(Or perhaps I did something incorrectly myself when I followed along in chapter 8, and I'm only seeing the effect here.)

Note from the Author or Editor:
absolutely right, will fix...

In page 258, code snippet below "A Simple Mock to Unit Tests Our Initialize Function" the reader is instructed to add <a id="id_login">Sign in</a>, but in
the tip/suggestion paragraph on 260 the reader is reminded to add <div id="id_login">. It should be also an <a> tag.

Note from the Author or Editor:
confirmed. will fix in atlas.

The following code does not work with Django 1.6:

def validate_unique(self):
try:
self.instance.validate_unique()
except ValidationError:
self._update_errors({'text': [DUPLICATE_ITEM_ERROR]})

The _update_errors() method expects an error with an 'error_dict' attribute and not the dict itself. The base method in django.forms.BaseModelForm passes the ValidationError instance itself to _update_errors(). Therefore the following fix is working:

def validate_unique(self):
try:
self.instance.validate_unique()
except ValidationError as e:
e.error_dict = {'text': [DUPLICATE_ITEM_ERROR]}
self._update_errors(e)

Note from the Author or Editor:
to be fixed as part of upgrade to 1.6

The showed template snipped should be in lists/templates/base.html instead of lists/templates/home.html.

Note from the Author or Editor:
fixed in latest draft

The first listing should be in lists/templates/base.html instead of lists/templates/home.html. The test should go into lists/tests/test_views.py instead of lists/test_views.py that does not exist if you follow the guideline in previous chapters.

Note from the Author or Editor:
fixed in latest draft

just adding {% block %} tags around a template block does not make it necessary to use {% block ... %}{{ block.super }}{% endblock %} in derived templates, instead it is necessary to define an empty block in derived templates that do not need the block.

Note from the Author or Editor:
fixed in latest draft

the listing should be for file lists/tests/test_views.py instead of lists/tests.py

Code snippet requires "import logging"

Note from the Author or Editor:
Iain is correct, will fix it on atlas

Below *Moving Down to the Forms Layer* header, in NewListForm's code. The save method
lacks an equal sign to list_. owner.


It's shown as:
if owner:
list_.owner owner


Should be:
if owner:
list_.owner = owner

Note from the Author or Editor:
this is fixed in the latest release, anton must be reading an old version.

In the newest version of Ansible (1.9.2. just tested) the $inventory_hostname does not work any more.

In the code listing for 'deploy_tools/provision.ansible.yaml':
vars:
host: $inventory_hostname

should be replaced with

vars:
host: "{{ inventory_hostname }}

or the variable 'host' could be replace with 'inventory_hostname' at all places.

Note from the Author or Editor:
have fixed in latest draft.

command line operation:

# mv functional_tests.py superlists/

is not consistent with the resulting git status in the following paragraphs.

It is also not consistent with the source code bundle.
After cloning it, do a `git checkout chapter_01`
to see for yourself.
It is also not inside the superlists directory when git is pointing at branches chapter_02 nor chapter_03.

Note from the Author or Editor:
2e is out, so wontfix.