© Giuliana Carullo 2020
G. CarulloImplementing Effective Code Reviewshttps://doi.org/10.1007/978-1-4842-6162-0_4

4. Design Smells

Giuliana Carullo1 
Dublin, Ireland

I think that there are certain crimes which the law cannot touch, and which therefore, to some extent, justify private revenge.

—Sherlock Holmes in Sir Arthur Conan Doyle’s “The Adventure of Charles Augustus Milverton” (1904)

Not sure if Doyle was thinking about code smells as a crime, but in my opinion it might!

Code reviews are useful in finding defects in portions of code (i.e., a method or a class). However, you have to remember that the code design and architecture can smell, too. Reviewing the architecture aims at considering bigger chunks of code and interactions between components ...

Get Implementing Effective Code Reviews: How to Build and Maintain Clean Code now with the O’Reilly learning platform.

O’Reilly members experience live online training, plus books, videos, and digital content from nearly 200 publishers.