June 2018
Beginner
178 pages
4h 29m
English
So far, we have seen how conversations begin, but what happens when the changes you made need some tweaking to be considered as ready to merge?
In this case, you can push new commits to the branch associated with the pull request and GitHub will pick up those changes and amend it. The new changes will show up and further feedback can be given. In The review process section, my evil twin, user axil42, raised a concern about a wrong line being committed. We will now make a new commit and push it to the update-readme branch and see what happens:
git checkout update-readme sed -i 's/Test change/For more info, check the wiki/' README.md # replace text git add README.md git commit -m 'Correct line in README.md' git push origin ...
Read now
Unlock full access