Pragmatic Unit Testing in Java with JUnit, 3rd Edition

Amplifying the Core Intent of Code

Let’s re-examine the slightly improved matches method:

utj3-refactor/07/src/main/java/iloveyouboss/Profile.java

public boolean matches(Criteria criteria) {
    score = 0;

    var kill = false;
    var anyMatches = false;
    for (var criterion: criteria) {
        var match = criterion.isMatch(profileAnswerMatching(criterion));
        if (!match && criterion.weight() == REQUIRED) {
            kill = true;
        }
        if (match) {
            score += criterion.weight().value();
        }
        anyMatches |= match;
    }
    if (kill)
        return false;

    return anyMatches;
}

Careful reading reveals the following outcomes:

• Return true if any criterion matches, false if none do.
• Calculate the score by summing the weights of matching ...