Pragmatic Unit Testing in Java with JUnit, 3rd Edition

Test Smell: Legacy Code Constructs

You’ll be making several passes through the test, each with a different intent.

A quick scan of the test reveals old-school Java and JUnit, evidenced by the lack of local variable type inferencing and the unnecessary use of public for the class and test method. One of the best things about the newer versions of both Java and JUnit is their ability to simplify your code.

First, make a couple of quick cleanup passes:

1. Remove public from the test class and test methods. They are clutter.
2. Replace local variable type names with the var type.

Here’s a snippet:

utj3-refactor-tests/02/src/test/java/util/SearchTest.java

class SearchTest {
    @Test
    void testSearch() {
        try {
            var pageContent = "There are certain ...